rxrpc: Fix set but unused variable 'usage' in rxrpc_get_peer().
authorDavid S. Miller <davem@davemloft.net>
Thu, 19 May 2011 22:41:03 +0000 (18:41 -0400)
committerDavid S. Miller <davem@davemloft.net>
Thu, 19 May 2011 22:41:03 +0000 (18:41 -0400)
I backed off from trying to just eliminate this variable, since
transforming atomic_inc_return() into atomic_inc() takes away
the memory barriers.

Signed-off-by: David S. Miller <davem@davemloft.net>
net/rxrpc/ar-peer.c

index b6ff06351d677e631da7f7ef5503bc08d76933f0..2754f098d43633f80c0a39b7c34a35296d5523ea 100644 (file)
@@ -157,6 +157,7 @@ struct rxrpc_peer *rxrpc_get_peer(struct sockaddr_rxrpc *srx, gfp_t gfp)
        /* we can now add the new candidate to the list */
        peer = candidate;
        candidate = NULL;
+       usage = atomic_read(&peer->usage);
 
        list_add_tail(&peer->link, &rxrpc_peers);
        write_unlock_bh(&rxrpc_peer_lock);
@@ -171,7 +172,7 @@ success:
             &peer->srx.transport.sin.sin_addr,
             ntohs(peer->srx.transport.sin.sin_port));
 
-       _leave(" = %p {u=%d}", peer, atomic_read(&peer->usage));
+       _leave(" = %p {u=%d}", peer, usage);
        return peer;
 
        /* we found the peer in the list immediately */