ipvs: avoid netns exit crash on ip_vs_conn_drop_conntrack
authorJulian Anastasov <ja@ssi.bg>
Thu, 10 Jul 2014 06:24:01 +0000 (09:24 +0300)
committerSimon Horman <horms@verge.net.au>
Wed, 16 Jul 2014 00:39:28 +0000 (09:39 +0900)
commit 8f4e0a18682d91 ("IPVS netns exit causes crash in conntrack")
added second ip_vs_conn_drop_conntrack call instead of just adding
the needed check. As result, the first call still can cause
crash on netns exit. Remove it.

Signed-off-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Hans Schillstrom <hans@schillstrom.com>
Signed-off-by: Simon Horman <horms@verge.net.au>
net/netfilter/ipvs/ip_vs_conn.c

index a8eb0a89326ab504ec83421ea7b66aba3ab3a057..610e19c0e13fc82b15eb3fa1dd8328df29d9baa2 100644 (file)
@@ -797,7 +797,6 @@ static void ip_vs_conn_expire(unsigned long data)
                        ip_vs_control_del(cp);
 
                if (cp->flags & IP_VS_CONN_F_NFCT) {
-                       ip_vs_conn_drop_conntrack(cp);
                        /* Do not access conntracks during subsys cleanup
                         * because nf_conntrack_find_get can not be used after
                         * conntrack cleanup for the net.