Staging: bcm: Alter LOC for readability/understandability purposes
authorKevin McKinney <klmckinney1@gmail.com>
Wed, 28 Sep 2011 01:28:11 +0000 (21:28 -0400)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 30 Sep 2011 00:34:51 +0000 (17:34 -0700)
This patch alters a line of code to make it more readable
and easier to understand. The purpose of the original line
of code was to compute the amount of memory to request from
kmalloc. This mulit-step algorithm was being done in one
line of code, thus making it more difficult to understand.
Therefore, I split this algorithm into three logical steps.

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/bcm/Bcmchar.c

index 867c65c4375dd3bfed6195c2731991c295f09271..2fa658eb74dcda1e40fb1e8115a3d1281cccce30 100644 (file)
@@ -205,6 +205,7 @@ static long bcm_char_ioctl(struct file *filp, UINT cmd, ULONG arg)
                RDM_BUFFER  sRdmBuffer = {0};
                PCHAR temp_buff;
                UINT Bufflen;
+               u16 temp_value;
 
                /* Copy Ioctl Buffer structure */
                if (copy_from_user(&IoBuffer, argp, sizeof(IOCTL_BUFFER)))
@@ -221,7 +222,10 @@ static long bcm_char_ioctl(struct file *filp, UINT cmd, ULONG arg)
                        return -EINVAL;
                }
 
-               Bufflen = IoBuffer.OutputLength + (4 - IoBuffer.OutputLength%4)%4;
+               Bufflen = IoBuffer.OutputLength;
+               temp_value = 4 - (Bufflen % 4);
+               Bufflen += temp_value % 4;
+
                temp_buff = kmalloc(Bufflen, GFP_KERNEL);
                if (!temp_buff)
                        return -ENOMEM;