GlobalValue is always pointer type, so an assert isn't required.
authorSanjiv Gupta <sanjiv.gupta@microchip.com>
Tue, 28 Apr 2009 16:39:45 +0000 (16:39 +0000)
committerSanjiv Gupta <sanjiv.gupta@microchip.com>
Tue, 28 Apr 2009 16:39:45 +0000 (16:39 +0000)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@70300 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Target/PIC16/PIC16ISelLowering.cpp

index 605fbe9415568e7effde43e3fa90bd25c4a65d4e..87753f98c55d2ca4bc21ffd90a62b2c2a6034041 100644 (file)
@@ -483,13 +483,8 @@ bool PIC16TargetLowering::isRomAddress(const SDValue &Op) {
   // It is BUILD_PAIR((PIC16Lo TGA), (PIC16Hi TGA)) and Op is BUILD_PAIR
   SDValue TGA = Op.getOperand(0).getOperand(0);
   GlobalAddressSDNode *GSDN = dyn_cast<GlobalAddressSDNode>(TGA);
-  const Type *ValueType = GSDN->getGlobal()->getType();
+  int AddrSpace = GSDN->getGlobal()->getType()->getAddressSpace();
 
-  if (!isa<PointerType>(ValueType)) {
-    assert(0 && "TGA must be of a PointerType");
-  }
-
-  int AddrSpace = dyn_cast<PointerType>(ValueType)->getAddressSpace();
   if (AddrSpace == PIC16ISD::ROM_SPACE)
     return true;