dmaengine: idma64: useless use of min_t()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 14 Sep 2015 08:55:38 +0000 (11:55 +0300)
committerVinod Koul <vinod.koul@intel.com>
Fri, 25 Sep 2015 02:24:05 +0000 (07:54 +0530)
We use a pattern

x = min_t(u32, <LOG2_CONSTANT>, __ffs(expr));

There is no need to use min_t() since we can replace it by

x = __ffs(expr | <2^LOG2_CONST>);

and moreover guarantee that argument of __ffs() will be not zero.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
drivers/dma/idma64.c

index 13c52b87d59bc29cb254ffa938c973544adff0c5..e91e499b0d913cee26f06f6208f1c04289e59ea7 100644 (file)
@@ -257,7 +257,7 @@ static u64 idma64_hw_desc_fill(struct idma64_hw_desc *hw,
                dar = config->dst_addr;
                ctllo |= IDMA64C_CTLL_DST_FIX | IDMA64C_CTLL_SRC_INC |
                         IDMA64C_CTLL_FC_M2P;
-               src_width = min_t(u32, 2, __ffs(sar | hw->len));
+               src_width = __ffs(sar | hw->len | 4);
                dst_width = __ffs(config->dst_addr_width);
        } else {        /* DMA_DEV_TO_MEM */
                sar = config->src_addr;
@@ -265,7 +265,7 @@ static u64 idma64_hw_desc_fill(struct idma64_hw_desc *hw,
                ctllo |= IDMA64C_CTLL_DST_INC | IDMA64C_CTLL_SRC_FIX |
                         IDMA64C_CTLL_FC_P2M;
                src_width = __ffs(config->src_addr_width);
-               dst_width = min_t(u32, 2, __ffs(dar | hw->len));
+               dst_width = __ffs(dar | hw->len | 4);
        }
 
        lli->sar = sar;