Fix this recently moved code to use the correct type. CI is now a

ConstantInt, and SI is the original cast instruction. This fixes
PR2996.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@58549 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/lib/Transforms/Scalar/InstructionCombining.cpp b/lib/Transforms/Scalar/InstructionCombining.cpp
index 70b5aefa23c5a3c6f22f6ee999bb4c372a1c726b..75a1ffea6b5964ceea80e484560328443bc86f5e 100644 (file)
--- a/lib/Transforms/Scalar/InstructionCombining.cpp
+++ b/lib/Transforms/Scalar/InstructionCombining.cpp
@@ -8551,8 +8551,8 @@ Instruction *InstCombiner::visitSelectInstWithICmp(SelectInst &SI,
           In = InsertNewInstBefore(BinaryOperator::CreateAShr(In, Sh,
                                                           In->getName()+".lobit"),
                                    *ICI);
-          if (In->getType() != CI->getType())
-            In = CastInst::CreateIntegerCast(In, CI->getType(),
+          if (In->getType() != SI.getType())
+            In = CastInst::CreateIntegerCast(In, SI.getType(),
                                              true/*SExt*/, "tmp", ICI);
     
           if (Pred == ICmpInst::ICMP_SGT)

diff --git a/test/Transforms/InstCombine/pr2996.ll b/test/Transforms/InstCombine/pr2996.ll
new file mode 100644 (file)
index 0000000..3e7dfa2
--- /dev/null
+++ b/test/Transforms/InstCombine/pr2996.ll
@@ -0,0 +1,12 @@
+; RUN: llvm-as < %s | opt -instcombine
+; PR2996
+
+define void @func_53(i16 signext %p_56) nounwind {
+entry:
+       %0 = icmp sgt i16 %p_56, -1             ; <i1> [#uses=1]
+       %iftmp.0.0 = select i1 %0, i32 -1, i32 0                ; <i32> [#uses=1]
+       %1 = call i32 (...)* @func_4(i32 %iftmp.0.0) nounwind           ; <i32> [#uses=0]
+       ret void
+}
+
+declare i32 @func_4(...)