md/raid1: submit_bio_wait() returns 0 on success
authorJes Sorensen <Jes.Sorensen@redhat.com>
Tue, 20 Oct 2015 16:09:12 +0000 (12:09 -0400)
committerNeilBrown <neilb@suse.com>
Tue, 20 Oct 2015 20:20:15 +0000 (07:20 +1100)
This was introduced with 9e882242c6193ae6f416f2d8d8db0d9126bd996b
which changed the return value of submit_bio_wait() to return != 0 on
error, but didn't update the caller accordingly.

Fixes: 9e882242c6 ("block: Add submit_bio_wait(), remove from md")
Cc: stable@vger.kernel.org (v3.10)
Reported-by: Bill Kuzeja <William.Kuzeja@stratus.com>
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: NeilBrown <neilb@suse.com>
drivers/md/raid1.c

index ddd8a5f572aa1c023db07b3eab6b72bc0371c1dd..cfca6edf78139bddb68b1fd730cfe8eb875a4ae3 100644 (file)
@@ -2195,7 +2195,7 @@ static int narrow_write_error(struct r1bio *r1_bio, int i)
                bio_trim(wbio, sector - r1_bio->sector, sectors);
                wbio->bi_iter.bi_sector += rdev->data_offset;
                wbio->bi_bdev = rdev->bdev;
-               if (submit_bio_wait(WRITE, wbio) == 0)
+               if (submit_bio_wait(WRITE, wbio) < 0)
                        /* failure! */
                        ok = rdev_set_badblocks(rdev, sector,
                                                sectors, 0)