folly/test: correct an erroneous test for failed mmap
authorJim Meyering <meyering@fb.com>
Tue, 5 Aug 2014 20:16:15 +0000 (13:16 -0700)
committerSara Golemon <sgolemon@fb.com>
Thu, 14 Aug 2014 18:49:04 +0000 (11:49 -0700)
Summary:
* folly/test/AtomicHashArrayTest.cpp (MmapAllocator):
Upon failure, mmap returns MAP_FAILED, not NULL.

Test Plan:
fbconfig -r folly/test:atomic_hash_array_test && fbmake runtests

Reviewed By: mwang@fb.com

FB internal diff: D1481080

Tasks: 4846893

folly/test/AtomicHashArrayTest.cpp

index ad324874131f8e0fc7e5edb6bd50f229a282f5e9..40e11a90d0b0c5ed3b181eab2f0b2f2468b9a89a 100644 (file)
@@ -81,7 +81,7 @@ class MmapAllocator {
   T *allocate(size_t n) {
     void *p = mmap(nullptr, n * sizeof(T), PROT_READ | PROT_WRITE,
         MAP_SHARED | MAP_ANONYMOUS, -1, 0);
-    if (!p) throw std::bad_alloc();
+    if (p == MAP_FAILED) throw std::bad_alloc();
     return (T *)p;
   }