Use .zerofill on x86/darwin.
authorEvan Cheng <evan.cheng@apple.com>
Wed, 15 Feb 2006 01:56:23 +0000 (01:56 +0000)
committerEvan Cheng <evan.cheng@apple.com>
Wed, 15 Feb 2006 01:56:23 +0000 (01:56 +0000)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@26196 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Target/X86/X86AsmPrinter.cpp

index 7de9ef2b5ff3ab21c54e5d2dd527f26a5a124694..5a43f867fd5633bd11bbd791423bbacf2ff2a867 100644 (file)
@@ -96,24 +96,31 @@ bool X86SharedAsmPrinter::doFinalization(Module &M) {
 
     if (C->isNullValue() && /* FIXME: Verify correct */
         (I->hasInternalLinkage() || I->hasWeakLinkage() ||
-         I->hasLinkOnceLinkage())) {
+         I->hasLinkOnceLinkage() ||
+         (forDarwin && I->hasExternalLinkage() && !I->hasSection()))) {
       if (Size == 0) Size = 1;   // .comm Foo, 0 is undefined, avoid it.
-      SwitchSection(".data", I);
-      if (LCOMMDirective != NULL) {
-        if (I->hasInternalLinkage()) {
-          O << LCOMMDirective << name << "," << Size;
-          if (forDarwin)
-            O << "," << (AlignmentIsInBytes ? (1 << Align) : Align);
-        } else
-          O << COMMDirective  << name << "," << Size;
+      if (I->hasExternalLinkage()) {
+          O << "\t.global\t" << name << "\n";
+          O << "\t.zerofill __DATA__, __common, " << name << ", "
+            << Size << ", " << Align;
       } else {
-        if (I->hasInternalLinkage())
-          O <<"\t.local\t" << name << "\n";
-        O << COMMDirective  << name << "," << Size;
-        if (COMMDirectiveTakesAlignment)
-          O << "," << (AlignmentIsInBytes ? (1 << Align) : Align);
+        SwitchSection(".data", I);
+        if (LCOMMDirective != NULL) {
+          if (I->hasInternalLinkage()) {
+            O << LCOMMDirective << name << "," << Size;
+            if (forDarwin)
+              O << "," << (AlignmentIsInBytes ? (1 << Align) : Align);
+          } else
+            O << COMMDirective  << name << "," << Size;
+        } else {
+          if (I->hasInternalLinkage())
+            O << "\t.local\t" << name << "\n";
+          O << COMMDirective  << name << "," << Size;
+          if (COMMDirectiveTakesAlignment)
+            O << "," << (AlignmentIsInBytes ? (1 << Align) : Align);
+        }
+        O << "\t\t" << CommentString << " " << I->getName() << "\n";
       }
-      O << "\t\t" << CommentString << " " << I->getName() << "\n";
     } else {
       switch (I->getLinkage()) {
       case GlobalValue::LinkOnceLinkage: