goldfish: Add a FIXME note to the pipe driver
authorAlan Cox <alan@linux.intel.com>
Wed, 23 Jan 2013 14:13:18 +0000 (14:13 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 24 Jan 2013 21:51:38 +0000 (13:51 -0800)
Note a point in the pipe driver that wants future attention

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/platform/goldfish/goldfish_pipe.c

index 58dae1f1fdd486c364bd510fc46c314ee37f3c09..4f5aa831f5497948d3953db3820ac45a48a666d3 100644 (file)
@@ -300,6 +300,7 @@ static ssize_t goldfish_pipe_read_write(struct file *filp, char __user *buffer,
                int status, wakeBit;
 
                /* Ensure that the corresponding page is properly mapped */
+               /* FIXME: this isn't safe or sufficient - use get_user_pages */
                if (is_write) {
                        char c;
                        /* Ensure that the page is mapped and readable */