hwmon: (it87) Fix pwm sysfs attribute removal
authorGuenter Roeck <linux@roeck-us.net>
Fri, 27 Mar 2015 13:03:41 +0000 (06:03 -0700)
committerGuenter Roeck <linux@roeck-us.net>
Mon, 30 Mar 2015 15:12:16 +0000 (08:12 -0700)
Detection if a pwm channel is supported was wrong on removal,
causing the code to try removing non-existing sysfs attributes.
That didn't matter much because sysfs attribute removal of non-existing
files fails silently, and because the wrong evaluation always returned
false, but should nevertheless be fixed.

Reviewed-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/it87.c

index ab12dc2eb8966f1ee1cc5c2d4cfc30591f3bfb27..81a43db371f760ca6685a993ff1e7b9ddece2f73 100644 (file)
@@ -2079,7 +2079,7 @@ static void it87_remove_files(struct device *dev)
                                          it87_attributes_fan_div[i]);
        }
        for (i = 0; i < 3; i++) {
-               if (sio_data->skip_pwm & (1 << 0))
+               if (sio_data->skip_pwm & (1 << i))
                        continue;
                sysfs_remove_group(&dev->kobj, &it87_group_pwm[i]);
                if (has_old_autopwm(data))