[media] drivers/media/platform/blackfin/bfin_capture.c: fix error return code
authorPeter Senna Tschudin <peter.senna@gmail.com>
Thu, 6 Sep 2012 14:23:58 +0000 (11:23 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Sun, 23 Sep 2012 19:52:10 +0000 (16:52 -0300)
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Cc: Scott Jiang <scott.jiang.linux@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/platform/blackfin/bfin_capture.c

index 1677623d8296e72ecbf0a3246c9e7b4c5ee50beb..cb2eb26850b179738b49975ea47d82cada2d0d11 100644 (file)
@@ -968,6 +968,7 @@ static int __devinit bcap_probe(struct platform_device *pdev)
        if (!i2c_adap) {
                v4l2_err(&bcap_dev->v4l2_dev,
                                "Unable to find i2c adapter\n");
+               ret = -ENODEV;
                goto err_unreg_vdev;
 
        }