ASoC: rsnd: fixup rsnd_mod_call() behavior for debug
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Thu, 22 Oct 2015 03:14:02 +0000 (03:14 +0000)
committerMark Brown <broonie@kernel.org>
Thu, 22 Oct 2015 12:30:01 +0000 (13:30 +0100)
Indicating each module method as debug message before executing is
readable/understandable.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sh/rcar/core.c

index 6ef9a884ca7cf0959c3d781dc5b0a10d5a084bf3..c0182ac254c93022e8fcf0d0d683c7c004f9df72 100644 (file)
@@ -308,16 +308,14 @@ u32 rsnd_get_dalign(struct rsnd_mod *mod, struct rsnd_dai_stream *io)
        u8 val  = (mod->status >> __rsnd_mod_shift_##func) & 0xF;       \
        u8 add  = ((val + __rsnd_mod_add_##func) & 0xF);                \
        int ret = 0;                                                    \
-       int called = 0;                                                 \
-       if (val == __rsnd_mod_call_##func) {                            \
-               called = 1;                                             \
-               ret = (mod)->ops->func(mod, io, param);                 \
-       }                                                               \
+       int call = (val == __rsnd_mod_call_##func);                     \
        mod->status = (mod->status & ~mask) +                           \
                (add << __rsnd_mod_shift_##func);                       \
-       dev_dbg(dev, "%s[%d] 0x%08x %s\n",                              \
-               rsnd_mod_name(mod), rsnd_mod_id(mod), mod->status,      \
-               called ? #func : "");                                   \
+       dev_dbg(dev, "%s[%d]\t0x%08x %s\n",                             \
+               rsnd_mod_name(mod), rsnd_mod_id(mod),                   \
+               mod->status, call ? #func : "");                        \
+       if (call)                                                       \
+               ret = (mod)->ops->func(mod, io, param);                 \
        ret;                                                            \
 })