ath10k: fix num_sends_allowed replenishing
authorMichal Kazior <michal.kazior@tieto.com>
Wed, 18 Sep 2013 13:22:17 +0000 (15:22 +0200)
committerKalle Valo <kvalo@qca.qualcomm.com>
Fri, 20 Sep 2013 05:04:31 +0000 (08:04 +0300)
Commit e9bb0aa39 ("ath10k: delete struct ce_sendlist") broke
num_sends_allowed incrementing. num_sends_allowed
exceeded initial values and could overflow.

This code was supposed to replenish
num_sends_allowed for partial sendlist items (i.e.
before final sendlist item from a sendlist was
completed and could be processed by completion
handlers).

Fortunately it seems it did not cause any major breakage,
yet.

Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
drivers/net/wireless/ath/ath10k/pci.c

index f1faf4691f914f28c4742e9bdfc1a6ae18305a9f..dff23d97bed065d984efac3c481ce2b06fa6e675 100644 (file)
@@ -626,10 +626,6 @@ static void ath10k_pci_ce_send_done(struct ath10k_ce_pipe *ce_state)
        while (ath10k_ce_completed_send_next(ce_state, &transfer_context,
                                             &ce_data, &nbytes,
                                             &transfer_id) == 0) {
-               spin_lock_bh(&pipe_info->pipe_lock);
-               pipe_info->num_sends_allowed++;
-               spin_unlock_bh(&pipe_info->pipe_lock);
-
                compl = get_free_compl(pipe_info);
                if (!compl)
                        break;