ASoC: dapm: Fix _PRE and _POST events for DAPM performance improvements
authorMark Brown <broonie@opensource.wolfsonmicro.com>
Fri, 20 Jul 2012 16:29:34 +0000 (17:29 +0100)
committerMark Brown <broonie@opensource.wolfsonmicro.com>
Mon, 23 Jul 2012 09:39:54 +0000 (10:39 +0100)
Ever since the DAPM performance improvements we've been marking all widgets
as not dirty after each DAPM run. Since _PRE and _POST events aren't part
of the DAPM graph this has rendered them non-functional, they will never be
marked dirty again and thus will never be run again.

Fix this by skipping them when marking widgets as not dirty.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Acked-by: Liam Girdwood <lrg@ti.com>
Cc: stable@vger.kernel.org
sound/soc/soc-dapm.c

index f7a13f720529966f011fd767b224b6503eed68f4..025060b26fb7271a96f8bf53684809e5f7dcdc7f 100644 (file)
@@ -1598,7 +1598,15 @@ static int dapm_power_widgets(struct snd_soc_dapm_context *dapm, int event)
        }
 
        list_for_each_entry(w, &card->widgets, list) {
-               list_del_init(&w->dirty);
+               switch (w->id) {
+               case snd_soc_dapm_pre:
+               case snd_soc_dapm_post:
+                       /* These widgets always need to be powered */
+                       break;
+               default:
+                       list_del_init(&w->dirty);
+                       break;
+               }
 
                if (w->power) {
                        d = w->dapm;