firmware_loader: abort request if wait_for_completion is interrupted
authorMing Lei <ming.lei@canonical.com>
Mon, 12 Jan 2015 16:01:35 +0000 (00:01 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 3 Feb 2015 23:33:10 +0000 (15:33 -0800)
If current request is interrupted by signal, such as 'ctrl + c',
this request has to be aborted for the following reasons:

- the buf need to be removed from pending list
- same requests from other contexts need to be completed

Reported-by: Sasha Levin <sasha.levin@oracle.com>
Signed-off-by: Ming Lei <ming.lei@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/firmware_class.c

index 96d994a3537245467b9b910e504968836db6f946..5870ec35efe6d9df196606771d24c5a224cbe9d9 100644 (file)
@@ -927,6 +927,13 @@ static int _request_firmware_load(struct firmware_priv *fw_priv,
        retval = wait_for_completion_interruptible(&buf->completion);
 
        cancel_delayed_work_sync(&fw_priv->timeout_work);
+
+       if (retval == -ERESTARTSYS) {
+               mutex_lock(&fw_lock);
+               fw_load_abort(fw_priv);
+               mutex_unlock(&fw_lock);
+       }
+
        if (is_fw_load_aborted(buf))
                retval = -EAGAIN;
        else if (!buf->data)