reject invalid comma stuff with a message. We reject the case in
authorChris Lattner <sabre@nondot.org>
Fri, 23 Apr 2010 00:50:50 +0000 (00:50 +0000)
committerChris Lattner <sabre@nondot.org>
Fri, 23 Apr 2010 00:50:50 +0000 (00:50 +0000)
PR6888 with:

$ llvm-as t.ll
llvm-as: t.ll:2:29: error: expected metadata or 'align'
 store <3 x i32> %x, i32 1, i32 1>, <3 x i32>* %p
                            ^

instead of:

$ llvm-as t.ll
llvm-as:

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@102154 91177308-0d34-0410-b5e6-96231b3b80d8

lib/AsmParser/LLParser.cpp

index aa887d21777973b4c9840bb748390c06fa799131..45b88cc2a55427f4e57f634f09b937915a5e6802 100644 (file)
@@ -1170,10 +1170,10 @@ bool LLParser::ParseOptionalCommaAlign(unsigned &Alignment,
       return false;
     }
     
-    if (Lex.getKind() == lltok::kw_align) {
-      if (ParseOptionalAlignment(Alignment)) return true;
-    } else
-      return true;
+    if (Lex.getKind() != lltok::kw_align)
+      return Error(Lex.getLoc(), "expected metadata or 'align'");
+    
+    if (ParseOptionalAlignment(Alignment)) return true;
   }
 
   return false;