Various improvements suggested by Duncan

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@48325 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/include/llvm/Function.h b/include/llvm/Function.h
index 2ffd5eaacd1d98db9e0c8d30e481ce89ad354fa9..be7ea910495e11567b2bdac0a3c06642ff5ffb5d 100644 (file)
--- a/include/llvm/Function.h
+++ b/include/llvm/Function.h
@@ -144,10 +144,12 @@ public:
     SubclassData = (SubclassData & 1) | (CC << 1);
   }
   
-  /// getParamAttrs - Return the parameter attributes for this function.
+  /// getParamAttrs - Return the parameter attributes for this Function.
+  ///
   const PAListPtr &getParamAttrs() const { return ParamAttrs; }
 
   /// setParamAttrs - Set the parameter attributes for this Function.
+  ///
   void setParamAttrs(const PAListPtr &attrs) { ParamAttrs = attrs; }
 
   /// hasCollector/getCollector/setCollector/clearCollector - The name of the

diff --git a/include/llvm/Instructions.h b/include/llvm/Instructions.h
index d29e11ca2703fc4c1b961b50465bf1a7db6c2163..741153f2883cb46e3f4f9401e3e7496cf48cab0d 100644 (file)
--- a/include/llvm/Instructions.h
+++ b/include/llvm/Instructions.h
@@ -926,11 +926,11 @@ public:
     SubclassData = (SubclassData & 1) | (CC << 1);
   }
 
-  /// getParamAttrs - Return the PAListPtr for the parameter attributes of this
-  /// call.
+  /// getParamAttrs - Return the parameter attributes for this call.
+  ///
   const PAListPtr &getParamAttrs() const { return ParamAttrs; }
 
-  /// setParamAttrs - Sets the parameter attributes for this CallInst.
+  /// setParamAttrs - Sets the parameter attributes for this call.
   void setParamAttrs(const PAListPtr &Attrs) { ParamAttrs = Attrs; }
 
   /// @brief Determine whether the call or the callee has the given attribute.
@@ -1740,11 +1740,11 @@ public:
     SubclassData = CC;
   }
 
-  /// getParamAttrs - Return the parameter attribute list for this invoke.
+  /// getParamAttrs - Return the parameter attributes for this invoke.
   ///
   const PAListPtr &getParamAttrs() const { return ParamAttrs; }
 
-  /// setParamAttrs - Set the parameter attribute list for this invoke.
+  /// setParamAttrs - Set the parameter attributes for this invoke.
   ///
   void setParamAttrs(const PAListPtr &Attrs) { ParamAttrs = Attrs; }
 

diff --git a/include/llvm/ParameterAttributes.h b/include/llvm/ParameterAttributes.h
index 4a68a7d7b6ec31bd5c702af7dd29bc8495d95c91..5031d8467c8de2e9715363f818ee492facb1e3f3 100644 (file)
--- a/include/llvm/ParameterAttributes.h
+++ b/include/llvm/ParameterAttributes.h
@@ -120,7 +120,7 @@ public:
   static PAListPtr get(const ParamAttrsWithIndex *Attr, unsigned NumAttrs);
   
   /// get - Return a ParamAttr list with the parameters specified by the
-  /// consequtive random access iterator range.
+  /// consecutive random access iterator range.
   template <typename Iter>
   static PAListPtr get(const Iter &I, const Iter &E) {
     if (I == E) return PAListPtr();  // Empty list.
@@ -161,7 +161,7 @@ public:
   /// least one parameter or for the return value.
   bool hasAttrSomewhere(ParameterAttributes Attr) const;
 
-  /// operator< - Provide an ordering for parameter attribute lists.
+  /// operator==/!= - Provide equality predicates.
   bool operator==(const PAListPtr &RHS) const { return PAList == RHS.PAList; }
   bool operator!=(const PAListPtr &RHS) const { return PAList != RHS.PAList; }
   

diff --git a/lib/VMCore/ParameterAttributes.cpp b/lib/VMCore/ParameterAttributes.cpp
index 7501a350878fa387085993b49dff5054b571a480..b5fb832fde6389e1c984554ac9fea433dcdd7586 100644 (file)
--- a/lib/VMCore/ParameterAttributes.cpp
+++ b/lib/VMCore/ParameterAttributes.cpp
@@ -77,7 +77,7 @@ namespace llvm {
 class ParamAttributeListImpl : public FoldingSetNode {
   unsigned RefCount;
   
-  // ParamAttrsList is uniqued, these should not be publicly available
+  // ParamAttrsList is uniqued, these should not be publicly available.
   void operator=(const ParamAttributeListImpl &); // Do not implement
   ParamAttributeListImpl(const ParamAttributeListImpl &); // Do not implement
   ~ParamAttributeListImpl();                        // Private implementation