[media] tuners/xc2028: Replace memcpy with struct assignment
authorEzequiel Garcia <elezegarcia@gmail.com>
Tue, 23 Oct 2012 18:57:16 +0000 (15:57 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Thu, 27 Dec 2012 21:00:50 +0000 (19:00 -0200)
This kind of memcpy() is error-prone. Its replacement with a struct
assignment is prefered because it's type-safe and much easier to read.
Found by coccinelle. Hand patched and reviewed.
Tested by compilation only.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
identifier struct_name;
struct struct_name to;
struct struct_name from;
expression E;
@@
-memcpy(&(to), &(from), E);
+to = from;
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/tuners/tuner-xc2028.c

index 7bcb6b0ff1dff217bd717c2df46b20fb6e96b932..09451737c77e8244339940cca83fcd0a9bbf67f1 100644 (file)
@@ -870,7 +870,7 @@ check_device:
        }
 
 read_not_reliable:
-       memcpy(&priv->cur_fw, &new_fw, sizeof(priv->cur_fw));
+       priv->cur_fw = new_fw;
 
        /*
         * By setting BASE in cur_fw.type only after successfully loading all