Summary: Our use case need to have the IndexType Configurable, but in this diff
D2583752, lint error shows
Code from folly::detail is logically private, please avoid use outside of folly.
In order to fix this lint error, I switch the IndexType and Allocator in the AtomicUnorderedInsertMap template.
Reviewed By: nbronson
Differential Revision:
D2610921
fb-gh-sync-id:
ae81b41e7c8c971f26c61b8c67dabeadff379584
(boost::has_trivial_destructor<Key>::value &&
boost::has_trivial_destructor<Value>::value),
template<typename> class Atom = std::atomic,
(boost::has_trivial_destructor<Key>::value &&
boost::has_trivial_destructor<Value>::value),
template<typename> class Atom = std::atomic,
- typename Allocator = folly::detail::MMapAlloc,
- typename IndexType = uint32_t>
+ typename IndexType = uint32_t,
+ typename Allocator = folly::detail::MMapAlloc>
struct AtomicUnorderedInsertMap {
struct AtomicUnorderedInsertMap {
KeyEqual,
SkipKeyValueDeletion,
Atom,
KeyEqual,
SkipKeyValueDeletion,
Atom,
- Allocator,
- uint64_t>;
-
+ uint64_t,
+ Allocator>;
/// MutableAtom is a tiny wrapper than gives you the option of atomically
/// updating values inserted into an AtomicUnorderedInsertMap<K,
/// MutableAtom is a tiny wrapper than gives you the option of atomically
/// updating values inserted into an AtomicUnorderedInsertMap<K,
(boost::has_trivial_destructor<Key>::value &&
boost::has_trivial_destructor<Value>::value),
Atom,
(boost::has_trivial_destructor<Key>::value &&
boost::has_trivial_destructor<Value>::value),
Atom,
- Allocator,
- IndexType>;
+ IndexType,
+ Allocator>;
namespace {
template <typename T>
namespace {
template <typename T>