make sure 'value' is not null. otherwise __ceph_setxattr will remove
the extended attribute.
Signed-off-by: Yan, Zheng <zyan@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>
struct ceph_pagelist *pagelist = NULL;
int err;
struct ceph_pagelist *pagelist = NULL;
int err;
/* copy value into pagelist */
pagelist = kmalloc(sizeof(*pagelist), GFP_NOFS);
if (!pagelist)
/* copy value into pagelist */
pagelist = kmalloc(sizeof(*pagelist), GFP_NOFS);
if (!pagelist)
err = ceph_pagelist_append(pagelist, value, size);
if (err)
goto out;
err = ceph_pagelist_append(pagelist, value, size);
if (err)
goto out;
flags |= CEPH_XATTR_REMOVE;
}
flags |= CEPH_XATTR_REMOVE;
}
if (!strncmp(name, XATTR_SYSTEM_PREFIX, XATTR_SYSTEM_PREFIX_LEN))
return generic_setxattr(dentry, name, value, size, flags);
if (!strncmp(name, XATTR_SYSTEM_PREFIX, XATTR_SYSTEM_PREFIX_LEN))
return generic_setxattr(dentry, name, value, size, flags);
+ if (size == 0)
+ value = ""; /* empty EA, do not remove */
+
return __ceph_setxattr(dentry, name, value, size, flags);
}
return __ceph_setxattr(dentry, name, value, size, flags);
}