net: dsa: do not call phy_start_aneg
authorFlorian Fainelli <f.fainelli@gmail.com>
Fri, 3 Oct 2014 01:56:03 +0000 (18:56 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sun, 5 Oct 2014 00:44:44 +0000 (20:44 -0400)
commitf7d6b96f345be7e0bd8f7651f7fe1efa5404c1e3
tree4d941d54f12e670bda8a976549b20ed8e755107a
parentdd3619f2ed5bd5ffce90f4fd8361ccd46d59b9b6
net: dsa: do not call phy_start_aneg

Commit f7f1de51edbd ("net: dsa: start and stop the PHY state machine")
add calls to phy_start() in dsa_slave_open() respectively phy_stop() in
dsa_slave_close().

We also call phy_start_aneg() in dsa_slave_create(), and this call is
messing up with the PHY state machine, since we basically start the
auto-negotiation, and later on restart it when calling phy_start().
phy_start() does not currently handle the PHY_FORCING or PHY_AN states
properly, but such a fix would be too invasive for this window.

Fixes: f7f1de51edbd ("net: dsa: start and stop the PHY state machine")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/dsa/slave.c