Module: Don't rename in getOrInsertFunction()
authorDuncan P. N. Exon Smith <dexonsmith@apple.com>
Mon, 10 Mar 2014 23:42:28 +0000 (23:42 +0000)
committerDuncan P. N. Exon Smith <dexonsmith@apple.com>
Mon, 10 Mar 2014 23:42:28 +0000 (23:42 +0000)
commitf5d17528ee24cfd3f77a4b11b82486a5a9a6d920
treeda650c71822c517b09ea70c47183061f6fb5c424
parent6df2b690989f499965640305b2045142192eca74
Module: Don't rename in getOrInsertFunction()

During LTO, user-supplied definitions of C library functions often
exist.  -instcombine uses Module::getOrInsertFunction() to get a handle
on library functions (e.g., @puts, when optimizing @printf).

Previously, Module::getOrInsertFunction() would rename any matching
functions with local linkage, and create a new declaration.  In LTO,
this is the opposite of desired behaviour, as it skips by the
user-supplied version of the library function and creates a new
undefined reference which the linker often cannot resolve.

After some discussing with Rafael on the list, it looks like it's
undesired behaviour.  If a consumer actually *needs* this behaviour, we
should add new API with a more explicit name.

I added two testcases: one specifically for the -instcombine behaviour
and one for the LTO flow.

<rdar://problem/16165191>

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203513 91177308-0d34-0410-b5e6-96231b3b80d8
lib/IR/Module.cpp
test/LTO/keep-used-puts-during-instcombine.ll [new file with mode: 0644]
test/LTO/no-undefined-puts-when-implemented.ll [new file with mode: 0644]