Remove the API for creating ConstantExprs with the nsw, nuw, inbounds,
authorDan Gohman <gohman@apple.com>
Thu, 3 Sep 2009 22:17:40 +0000 (22:17 +0000)
committerDan Gohman <gohman@apple.com>
Thu, 3 Sep 2009 22:17:40 +0000 (22:17 +0000)
commite56a94ef91009ddb8d8b68783ff1650bcad3b326
tree1c8c18901981239213e9c0c60e52786bd8916c38
parent5e41178a6ee9a0faa2c031811d32543d7e9d0aff
Remove the API for creating ConstantExprs with the nsw, nuw, inbounds,
and exact flags. Because ConstantExprs are uniqued, creating an
expression with this flag causes all expressions with the same operands
to have the same flag, which may not be safe. Add, sub, mul, and sdiv
ConstantExprs are usually folded anyway, so the main interesting flag
here is inbounds, and the constant folder already knows how to set the
inbounds flag automatically in most cases, so there isn't an urgent need
for the API support.

This can be reconsidered in the future, but for now just removing these
API bits eliminates a source of potential trouble with little downside.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@80959 91177308-0d34-0410-b5e6-96231b3b80d8
include/llvm-c/Core.h
include/llvm/Constants.h
include/llvm/Support/ConstantFolder.h
include/llvm/Support/NoFolder.h
include/llvm/Support/TargetFolder.h
lib/Analysis/ConstantFolding.cpp
lib/VMCore/ConstantFold.cpp
lib/VMCore/Constants.cpp
lib/VMCore/Core.cpp