(Wangle) Fix Executor problem
authorHannes Roth <hannesr@fb.com>
Fri, 1 May 2015 16:22:05 +0000 (09:22 -0700)
committerPraveen Kumar Ramakrishnan <praveenr@fb.com>
Tue, 12 May 2015 00:02:04 +0000 (17:02 -0700)
commite4e2520ac491eb7d13cde8aea87dd8668b622da0
tree1f5edebd05956ac48b4940055feb32a7bbc5c048
parente9089c4aa7c8ae9ea202a41ceb29bcb8fecea02c
(Wangle) Fix Executor problem

Summary:
None of these functions should be templated with `class Executor`.
Except `then(Executor, Args...)` because otherwise the compiler gets
confused. This was the combination that worked for both Clang and GCC,
don't ask me why. I'm assuming this puts it on a low priority...

I think this is also OK, because `setExecutor` takes an actual
`folly::Executor`, so even `then(Executor, Args...)` won't just work for any
`Executor`.

Test Plan: Run all the tests.

Reviewed By: jsedgwick@fb.com

Subscribers: folly-diffs@, jsedgwick, yfeldblum, chalfant

FB internal diff: D2036912

Tasks: 6838553

Signature: t1:2036912:1430493088:44f2ffe146298c3f978ac27a45b9b2e33b2b0422
folly/futures/Future-inl.h
folly/futures/Future.h
folly/futures/helpers.h
folly/futures/test/ViaTest.cpp