UPSTREAM: pinctrl: rockchip: add missing of_node_put
authorJulia Lawall <Julia.Lawall@lip6.fr>
Mon, 21 Dec 2015 16:39:47 +0000 (17:39 +0100)
committerHuang, Tao <huangtao@rock-chips.com>
Mon, 15 Feb 2016 08:41:45 +0000 (16:41 +0800)
commite4597d306963587cdd4055500a85b74bee3e2c43
tree1d5cd2d8278cf49c0d0a670f8035a77a0cf1a74d
parent96f3a06f76351564d3f935b2f26dff624d8199f1
UPSTREAM: pinctrl: rockchip: add missing of_node_put

for_each_child_of_node performs an of_node_get on each iteration, so a
return from the loop requires an of_node_put.

A simplified version of the semantic patch that fixes this problem is as
follows (http://coccinelle.lip6.fr):

// <smpl>
@@
local idexpression n;
expression e,e1;
@@

 for_each_child_of_node(e1,n) {
   ...
(
   of_node_put(n);
|
   e = n
|
   return n;
|
+  of_node_put(n);
?  return ...;
)
   ...
 }
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
(cherry picked from commit f7a81b7f4e9830323a7bbee8c4c7ab4c7c7ff6f4)

Change-Id: Ib0eb8520fbb3d83fc67135634c4f17112e73f215
drivers/pinctrl/pinctrl-rockchip.c