UBI: replace memcpy with struct assignment
authorEzequiel Garcia <elezegarcia@gmail.com>
Fri, 23 Nov 2012 11:58:05 +0000 (08:58 -0300)
committerArtem Bityutskiy <artem.bityutskiy@linux.intel.com>
Mon, 3 Dec 2012 11:54:14 +0000 (13:54 +0200)
commitd856c13c11d81dfa545f927db8d31663d45bbc94
tree7253bc3605cbfb66a502ea54f62927a14e041d2c
parent38f92cca8aae5b2e4ff2700c47eee0b807e22980
UBI: replace memcpy with struct assignment

This kind of memcpy() is error-prone. Its replacement with a struct
assignment is prefered because it's type-safe and much easier to read.

Found by coccinelle. Hand patched and reviewed.
Tested by compilation only.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
identifier struct_name;
struct struct_name to;
struct struct_name from;
expression E;
@@
-memcpy(&(to), &(from), E);
+to = from;
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
drivers/mtd/ubi/build.c
drivers/mtd/ubi/upd.c
drivers/mtd/ubi/vmt.c