iscsi-target: Fix ERL=2 ASYNC_EVENT connection pointer bug
authorNicholas Bellinger <nab@linux-iscsi.org>
Wed, 19 Feb 2014 23:32:14 +0000 (23:32 +0000)
committerNicholas Bellinger <nab@linux-iscsi.org>
Mon, 7 Apr 2014 08:48:52 +0000 (01:48 -0700)
commitd444edc679e7713412f243b792b1f964e5cff1e1
tree741d5b8acb70e1c986df5f2e7d2edc7984ce74d7
parentf225225848a70006d039b4caa2a089b660756cd5
iscsi-target: Fix ERL=2 ASYNC_EVENT connection pointer bug

This patch fixes a long-standing bug in iscsit_build_conn_drop_async_message()
where during ERL=2 connection recovery, a bogus conn_p pointer could
end up being used to send the ISCSI_OP_ASYNC_EVENT + DROPPING_CONNECTION
notifying the initiator that cmd->logout_cid has failed.

The bug was manifesting itself as an OOPs in iscsit_allocate_cmd() with
a bogus conn_p pointer in iscsit_build_conn_drop_async_message().

Reported-by: Arshad Hussain <arshad.hussain@calsoftinc.com>
Reported-by: santosh kulkarni <santosh.kulkarni@calsoftinc.com>
Cc: <stable@vger.kernel.org> #3.1+
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/target/iscsi/iscsi_target.c