Fix a theoretical problem (not seen in the wild): if different instances of a
authorDuncan Sands <baldrick@free.fr>
Tue, 29 Nov 2011 18:26:38 +0000 (18:26 +0000)
committerDuncan Sands <baldrick@free.fr>
Tue, 29 Nov 2011 18:26:38 +0000 (18:26 +0000)
commitd3a38ccfbb6be0edad037961df77649db2cb9597
tree5f10e303496ad46ac2743a1576b6568257e1552a
parent116bc795da4b10773235a89cc251d31651b3851d
Fix a theoretical problem (not seen in the wild): if different instances of a
weak variable are compiled by different compilers, such as GCC and LLVM, while
LLVM may increase the alignment to the preferred alignment there is no reason to
think that GCC will use anything more than the ABI alignment.  Since it is the
GCC version that might end up in the final program (as the linkage is weak), it
is wrong to increase the alignment of loads from the global up to the preferred
alignment as the alignment might only be the ABI alignment.

Increasing alignment up to the ABI alignment might be OK, but I'm not totally
convinced that it is.  It seems better to just leave the alignment of weak
globals alone.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@145413 91177308-0d34-0410-b5e6-96231b3b80d8
lib/Analysis/ValueTracking.cpp
lib/Transforms/Utils/Local.cpp
test/Transforms/InstCombine/align-external.ll