Don't rely on implicit lookup of member names in dependent base classes
authorChristopher Dykes <cdykes@fb.com>
Fri, 18 Nov 2016 00:30:31 +0000 (16:30 -0800)
committerFacebook Github Bot <facebook-github-bot-bot@fb.com>
Fri, 18 Nov 2016 00:38:38 +0000 (16:38 -0800)
commitbe0254f343c83fd05fb5efefd9894821f59e1c77
tree17b90f53405a86516d086f1cff962ef23041acbf
parent1f5e574d873668adbfd0c392e01ee766a39a13c2
Don't rely on implicit lookup of member names in dependent base classes

Summary:
The standard says this shouldn't be done, but GCC, Clang, and MSVC all do, at least, MSVC does if you don't pass the `/permissive-` switch to disable this non-compliant lookup.
This just qualifies it with `this->` which solves the problem.

MSVC plans to eventually (some time after the 2017 release) enable `/permissive-` by default, so let's start compiling with it now.

Reviewed By: yfeldblum

Differential Revision: D4200725

fbshipit-source-id: 8545c6bcda9ba6006733c15f668805cb1260517a
folly/test/DeterministicSchedule.cpp