virtio_balloon: fix race by fill and leak
authorMinchan Kim <minchan@kernel.org>
Sun, 27 Dec 2015 23:35:12 +0000 (08:35 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 3 Mar 2016 23:07:17 +0000 (15:07 -0800)
commitac3981b170863371c0386f9578d6bf4b8f961cc0
tree06c18c4849920a43cda4973ef235a1edcabcc49e
parent7d661c4658ce4485d5737eb522303d6eefa42749
virtio_balloon: fix race by fill and leak

commit f68b992bbb474641881932c61c92dcfa6f5b3689 upstream.

During my compaction-related stuff, I encountered a bug
with ballooning.

With repeated inflating and deflating cycle, guest memory(
ie, cat /proc/meminfo | grep MemTotal) is decreased and
couldn't be recovered.

The reason is balloon_lock doesn't cover release_pages_balloon
so struct virtio_balloon fields could be overwritten by race
of fill_balloon(e,g, vb->*pfns could be critical).

This patch fixes it in my test.

Signed-off-by: Minchan Kim <minchan@kernel.org>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/virtio/virtio_balloon.c