folly: fix clang -Wpessimizing-move
authorIgor Sugak <sugak@fb.com>
Tue, 13 Oct 2015 00:15:20 +0000 (17:15 -0700)
committerfacebook-github-bot-4 <folly-bot@fb.com>
Tue, 13 Oct 2015 05:21:05 +0000 (22:21 -0700)
commita2bab0fb305e8f3c073316c3c2575630a5b9ac31
tree0b013453cfc286a6d85c3a03ebd7056c61650fd0
parent09417cff863744a9e1aed90d243ceae8bda3cd3b
folly: fix clang -Wpessimizing-move

Summary: Make folly `-Wpessimizing-move` clean:

Common errors:
```lang=bash
folly/io/test/NetworkBenchmark.cpp:71:30: error: moving a temporary object prevents copy elision [-Werror,-Wpessimizing-move]
    unique_ptr<IOBuf> next = std::move(head->pop());
                             ^
folly/io/IOBufQueue.cpp:153:28: error: moving a temporary object prevents copy elision [-Werror,-Wpessimizing-move]
      appendToChain(head_, std::move(
                           ^
folly/IPAddressV6.cpp:341:12: error: moving a local object in a return statement prevents copy elision [-Werror,-Wpessimizing-move]
    return std::move(ip);
           ^
folly/IPAddressV6.cpp:341:12: note: remove std::move call here
    return std::move(ip);
           ^~~~~~~~~~  ~
1 error generated.
```

Reviewed By: @fugalh, @meyering

Differential Revision: D2526950

fb-gh-sync-id: 49291a8b49905eb9b2042d004830ff2f599dfbd3
folly/IPAddressV6.cpp
folly/io/IOBufQueue.cpp
folly/io/async/AsyncSocket.cpp
folly/io/test/IOBufQueueTest.cpp
folly/io/test/NetworkBenchmark.cpp