abort instead of throwing an exception on bad format strings
authorbsimmers <bsimmers@fb.com>
Tue, 27 Aug 2013 23:27:09 +0000 (16:27 -0700)
committerJordan DeLong <jdelong@fb.com>
Sun, 8 Sep 2013 01:51:00 +0000 (18:51 -0700)
commit9bfa4150776b1373827cd1104de852ec91350376
treed7d1da43799aff4507f278472180d4a5b599d4c6
parent38220af4dc50f723282e7b7bf592ad595468e0b9
abort instead of throwing an exception on bad format strings

Summary:
Errors that happen during format are almost always programmer
error in the form of a bad format string. Abort instead of throwing in
these cases.

Test Plan: automated tests, added a couple new tests

Reviewed By: tudorb@fb.com

FB internal diff: D947470
folly/Format-inl.h
folly/Format.cpp
folly/FormatArg.h
folly/test/FormatTest.cpp