Revert "Add r159136 back now that pr13124 has been fixed."
authorRafael Espindola <rafael.espindola@gmail.com>
Wed, 4 Sep 2013 16:09:01 +0000 (16:09 +0000)
committerRafael Espindola <rafael.espindola@gmail.com>
Wed, 4 Sep 2013 16:09:01 +0000 (16:09 +0000)
commit9718158222ad9c52b2fb14609a341d4e24def8bb
tree7aeaa76fe84666731515e4840a2545e6f392ec0a
parent280e5eef43ecf2279ab78f132922920ed7ce7952
Revert "Add r159136 back now that pr13124 has been fixed."

This reverts commit r189886.

I found a corner case where this optimization is not valid:

Say we have a "linkonce_odr unnamed_addr" in two translation units:
* In TU 1 this optimization kicks in and makes it hidden.
* In TU 2 it gets const merged with a constant that is *not* unnamed_addr,
  resulting in a non unnamed_addr constant with default visibility.
* The static linker rules for combining visibility them produce a hidden
  symbol, which is incorrect from the point of view of the non unnamed_addr
  constant.

The one place we can do this is when we know that the symbol is not used from
another TU in the same shared object, i.e., during LTO. I will move it there.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@189954 91177308-0d34-0410-b5e6-96231b3b80d8
include/llvm/IR/GlobalValue.h
lib/Transforms/IPO/GlobalOpt.cpp
test/Transforms/GlobalOpt/hidden.ll [deleted file]