kvm: x86: Check memopp before dereference (CVE-2016-8630)
authorOwen Hofmann <osh@google.com>
Thu, 27 Oct 2016 18:25:52 +0000 (11:25 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 10 Nov 2016 15:36:37 +0000 (16:36 +0100)
commit91e1f7b0eb252ce8f88d69227ef5f52f9efb2aae
tree0e942486ede38cec21fc09ec13e66ad31c352efa
parent62fa839b8fff08425bcc6bcdd5533ef4a267aa87
kvm: x86: Check memopp before dereference (CVE-2016-8630)

commit d9092f52d7e61dd1557f2db2400ddb430e85937e upstream.

Commit 41061cdb98 ("KVM: emulate: do not initialize memopp") removes a
check for non-NULL under incorrect assumptions. An undefined instruction
with a ModR/M byte with Mod=0 and R/M-5 (e.g. 0xc7 0x15) will attempt
to dereference a null pointer here.

Fixes: 41061cdb98a0bec464278b4db8e894a3121671f5
Message-Id: <1477592752-126650-2-git-send-email-osh@google.com>
Signed-off-by: Owen Hofmann <osh@google.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/x86/kvm/emulate.c