unittests: Actually test reverse iterators in Path tests
authorJustin Bogner <mail@justinbogner.com>
Wed, 16 Jul 2014 08:18:58 +0000 (08:18 +0000)
committerJustin Bogner <mail@justinbogner.com>
Wed, 16 Jul 2014 08:18:58 +0000 (08:18 +0000)
commit8fa83afb83ea16e768db8f515658b213a606863e
treef473e25017b2c60f7b9bfe304ac64cadc6a025af
parent55a421f98dbaa5ef179323bc4c78e601adf745e4
unittests: Actually test reverse iterators in Path tests

This re-enables some #if 0'd code (since 2010) in the Path unittests
and makes at least a weak effort at testing sys::path's rbegin/rend.

This change was inspired by some test failures near uses of rbegin and
rend here:

    http://lab.llvm.org:8011/builders/clang-x86_64-linux-vg/builds/3209

The "valgrind was whining" comment looked promising in terms of a
simpler to debug case of the same errors. However, it appears that the
valgrind complaints the comment was referring to are distinct from the
ones in the frontend, since this updated test isn't complaining for me
under valgrind.

In any case, the disabled tests weren't helping anybody.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@213125 91177308-0d34-0410-b5e6-96231b3b80d8
unittests/Support/Path.cpp