ext3: Fix error handling on inode bitmap corruption
authorJan Kara <jack@suse.cz>
Thu, 8 Dec 2011 20:13:46 +0000 (21:13 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 21 May 2012 16:40:04 +0000 (09:40 -0700)
commit8e8a21270cbfc41bf3bf2e014b99dc113ba554ec
tree12d5b48c6b64f63e8017c3c7036fd71dca4fccf0
parent5c17daa89308cc028fe336af58cf9d4e4d83298d
ext3: Fix error handling on inode bitmap corruption

commit 1415dd8705394399d59a3df1ab48d149e1e41e77 upstream.

When insert_inode_locked() fails in ext3_new_inode() it most likely
means inode bitmap got corrupted and we allocated again inode which
is already in use. Also doing unlock_new_inode() during error recovery
is wrong since inode does not have I_NEW set. Fix the problem by jumping
to fail: (instead of fail_drop:) which declares filesystem error and
does not call unlock_new_inode().

Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/ext3/ialloc.c