HID: uhid: fix leak for 64/32 UHID_CREATE
authorDavid Herrmann <dh.herrmann@gmail.com>
Tue, 26 Nov 2013 12:58:18 +0000 (13:58 +0100)
committerJiri Kosina <jkosina@suse.cz>
Wed, 27 Nov 2013 09:53:49 +0000 (10:53 +0100)
commit80897aa787ecd58eabb29deab7cbec9249c9b7e6
treeaaed88615f8a55457a850e5a3aff5b6e0a8175cc
parent8a396321e2102d98a0d387c773be13b55d88ae6f
HID: uhid: fix leak for 64/32 UHID_CREATE

UHID allows short writes so user-space can omit unused fields. We
automatically set them to 0 in the kernel. However, the 64/32 bit
compat-handler didn't do that in the UHID_CREATE fallback. This will
reveal random kernel heap data (of random size, even) to user-space.

Fixes: befde0226a59 ('HID: uhid: make creating devices work on 64/32 systems')
Reported-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
Cc: stable@vger.kernel.org
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/uhid.c