ACPI / osl: Kill macro INVALID_TABLE().
authorTang Chen <tangchen@cn.fujitsu.com>
Wed, 14 Aug 2013 09:37:08 +0000 (17:37 +0800)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Wed, 14 Aug 2013 21:24:01 +0000 (23:24 +0200)
commit7702ae0dd9b40930931914866999a2ac9734d3eb
tree2e9fc055c4b4ca5aa54408ebe1d69411d837c00d
parent598bae70c2a8e35c8d39b610cca2b32afcf047af
ACPI / osl: Kill macro INVALID_TABLE().

The macro INVALID_TABLE() is defined like this:

 #define INVALID_TABLE(x, path, name)                                    \
         { pr_err("ACPI OVERRIDE: " x " [%s%s]\n", path, name); continue; }

And it is used like this:

for (...) {
...
if (...)
INVALID_TABLE()
...
}

The "continue" in the macro makes the code hard to understand.

And also, this macro is only used several times in a single file.
As suggested by Joe Perches <joe@perches.com>, we can remote it and
use pr_err directly.

So after this patch, this macro is removed, and pr_err() is used
like this:

for (...) {
...
if (...) {
pr_err("ACPI OVERRIDE: ......");
continue;
}
...
}

Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
Suggested-by: Joe Perches <joe@perches.com>
Acked-by: Tejun Heo <tj@kernel.org>
Acked-by: Toshi Kani <toshi.kani@hp.com>
Reviewed-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/osl.c