mwifiex: avoid freeing improper pointer in mwifiex_set_wowlan_mef_entry
authorJohn Linville <linville@tuxdriver.com>
Tue, 23 Jun 2015 18:45:45 +0000 (14:45 -0400)
committerKalle Valo <kvalo@codeaurora.org>
Tue, 21 Jul 2015 13:44:21 +0000 (16:44 +0300)
commit722d26680af10bd128b5228ba23e5d11ef2256c4
tree6f12cb0e12a7cb8758ebf03420a81d267f3daabc
parent9030d52cfb340f57d86e1b5d995a463eaddb977b
mwifiex: avoid freeing improper pointer in mwifiex_set_wowlan_mef_entry

mwifiex_set_wowlan_mef_entry attempts to free a passed-in pointer in
case of an error.  The only caller (mwifiex_set_mef_filter) passes that
pointer as an offset into allocated memory, so any attempt to free that
will not be the actual allocated pointer.

Address this by changing mwifiex_set_wowlan_mef_entry to not do any
free, and to cause mwifiex_set_mef_filter to do the appropriate free if
the call to mwifiex_set_wowlan_mef_entry fails.

Coverity CID #1295879

Signed-off-by: John W. Linville <linville@tuxdriver.com>
Acked-by: Amitkumar Karwar <akarwar@marvell.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/mwifiex/cfg80211.c