mmc: sdhci: fix IS_ERR() checking of regulator_get()
authorKevin Liu <kliu5@marvell.com>
Wed, 17 Oct 2012 11:04:44 +0000 (19:04 +0800)
committerChris Ball <cjb@laptop.org>
Wed, 7 Nov 2012 20:02:04 +0000 (15:02 -0500)
commit657d59823c095e8f03e2744d765f53700331ff8f
tree33cb97164df514189cf478d4bcb7a327f2c0c856
parentee3298a2b6832bcfeec040dabf19632b704d826a
mmc: sdhci: fix IS_ERR() checking of regulator_get()

There are two problems here:

The check for vmmc was printing an unnecessary pr_info() when
host->vmmc is NULL.

The intent of the check for vqmmc was to only remove UHS if we have a
regulator that doesn't support the required voltage, but since IS_ERR()
doesn't catch NULL, we were actually removing UHS modes if vqmmc isn't
present at all -- since it isn't present for most users, this breaks
UHS for them.  This patch fixes that UHS regression in 3.7-rc1.

Signed-off-by: Kevin Liu <kliu5@marvell.com>
Signed-off-by: Bin Wang <binw@marvell.com>
Reviewed-by: Philip Rakity <prakity@marvell.com>
Signed-off-by: Chris Ball <cjb@laptop.org>
drivers/mmc/host/sdhci.c