SymbolizedFrame::name is already null-terminated
authorTudor Bosman <tudorb@fb.com>
Sun, 20 Apr 2014 15:02:08 +0000 (08:02 -0700)
committerDave Watson <davejwatson@fb.com>
Tue, 20 May 2014 19:53:56 +0000 (12:53 -0700)
commit5ed60bc7bfdde37f4ae530ebb22e9b074f092414
treef57b49f15c95e1e97e2aeb6c61b8523d0c0f14ac
parent2c73945cae93e33935f0c9730117ba78387cd987
SymbolizedFrame::name is already null-terminated

Summary:
... as it comes from Elf::getSymbolName, which returns null-terminated C
strings. So there's no need to copy it into a fixed-size buffer (and have a
buffer overflow, ouch).

Test Plan: folly/experimental/symbolizer_test, see what else "arc unit" gets us

Reviewed By: tconerly@fb.com

FB internal diff: D1286348
folly/experimental/symbolizer/Symbolizer.cpp
folly/experimental/symbolizer/Symbolizer.h
folly/experimental/symbolizer/test/SymbolizerTest.cpp