[SDAG] Actually check for a non-constant splat and clarify comments
authorChandler Carruth <chandlerc@gmail.com>
Tue, 8 Jul 2014 07:44:15 +0000 (07:44 +0000)
committerChandler Carruth <chandlerc@gmail.com>
Tue, 8 Jul 2014 07:44:15 +0000 (07:44 +0000)
commit5b0b023a6414064a944808499f0718372def98a8
tree7468b31cfb98776cb0146acc8f408c4acf578e8b
parent9b187c9b9b8a5cfe5a771a8b4d429e9ef4fb0115
[SDAG] Actually check for a non-constant splat and clarify comments
around the handling of UNDEF lanes in boolean vector content analysis.

The code before my changes here also failed to check for non-constant
splats in a buildvector. I have no idea how to trigger this, I just
spotted by inspection when trying to understand the code. It seems
extremely unlikely to be worth the trouble to teach the only caller of
this code (DAG combining setcc patterns) how to cleverly handle undef
lanes, so I've just commented more thoroughly that we're giving up
there.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@212515 91177308-0d34-0410-b5e6-96231b3b80d8
lib/CodeGen/SelectionDAG/TargetLowering.cpp