Fix an overly general check in SimplifyIndvar to handle useless phi cycles.
authorAndrew Trick <atrick@apple.com>
Thu, 17 Nov 2011 23:36:35 +0000 (23:36 +0000)
committerAndrew Trick <atrick@apple.com>
Thu, 17 Nov 2011 23:36:35 +0000 (23:36 +0000)
commit4f3052403ca5ea9542a118c2e54ff9c82038f41c
tree1dd30660130db7eec9772488e057b352767226cb
parent7cf2a04361e8613264498e50babe52d65c070473
Fix an overly general check in SimplifyIndvar to handle useless phi cycles.

The right way to check for a binary operation is
cast<BinaryOperator>. The original check: cast<Instruction> &&
numOperands() == 2 would match phi "instructions", leading to an
infinite loop in extreme corner case: a useless phi with operands
[self, constant] that prior optimization passes failed to remove,
being used in the loop by another useless phi, in turn being used by an
lshr or udiv.

Fixes PR11350: runaway iteration assertion.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@144935 91177308-0d34-0410-b5e6-96231b3b80d8
lib/Transforms/Utils/SimplifyIndVar.cpp
test/Transforms/IndVarSimplify/2011-11-17-selfphi.ll [new file with mode: 0644]