drm/i915: fix driver's versions of WARN_ON & WARN_ON_ONCE
authorDave Gordon <david.s.gordon@intel.com>
Mon, 17 Aug 2015 16:30:52 +0000 (17:30 +0100)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 26 Aug 2015 07:59:28 +0000 (09:59 +0200)
commit4eee4920f05e39e22571deb57f1c314ce7a46e7f
tree417b4bcfbabb8dfa0f2091d5a536f9ea625ebe35
parent901c2daf05c8ae6c3f85370fc96b9b6892f5da2d
drm/i915: fix driver's versions of WARN_ON & WARN_ON_ONCE

The current versions of these two macros don't work correctly if the
argument expression happens to contain a modulo operator (%) -- when
stringified, it gets interpreted as a printf formatting character!
With a specifically crafted parameter, this could probably cause a
kernel OOPS; consider WARN_ON(p%s) or WARN_ON(f %*pEp).

Instead, we should use an explicit "%s" format, with the stringified
expression as the coresponding literal-string argument.

Signed-off-by: Dave Gordon <david.s.gordon@intel.com>
Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/i915_drv.h