projects / oota-llvm.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 81c5d11) | patch
CodeGenSchedule: smallvector.push_back(smallvector[0]) is dangerous
authorArnold Schwaighofer <aschwaighofer@apple.com>
Thu, 6 Jun 2013 23:23:14 +0000 (23:23 +0000)
committerArnold Schwaighofer <aschwaighofer@apple.com>
Thu, 6 Jun 2013 23:23:14 +0000 (23:23 +0000)
commit45dc03287e29affeeb7e1f1281fca63d8b9773b1
tree35f1677ebd46e851c5ff7d640491307eedb2ce80tree | snapshot
parent81c5d11c25690cdb6282eb0ceb79f487325ce1e6commit | diff
CodeGenSchedule: smallvector.push_back(smallvector[0]) is dangerous

The element passed to push_back is not copied before the vector reallocates.
The client needs to copy the element first before passing it to push_back.

No test case, will be tested by follow-up swift scheduler model change (it
segfaults without this change).

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@183459 91177308-0d34-0410-b5e6-96231b3b80d8
utils/TableGen/CodeGenSchedule.cpp diff | blob | history
C/C++ LLVM-based compilers that forbids OOTA behaviors