ext4: don't kfree uninitialized s_group_info members
authorEric Sandeen <sandeen@redhat.com>
Tue, 22 Mar 2011 01:25:13 +0000 (21:25 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Tue, 22 Mar 2011 01:25:13 +0000 (21:25 -0400)
commit4596fe07679ff0fae904515691ea747467614871
treee15520e06d5c72702dc84e4eda4179ee9dc5c294
parent21149d611ecd0faf60f4ef94aa2bf8ed872f92bf
ext4: don't kfree uninitialized s_group_info members

We can call kfree on uninitialized members of the s_group_info array
on an the error path.  We can avoid this by kzalloc'ing the array.

This doesn't entirely solve the oops on mount if we fail down this
path; failed_mount4: frees the sbi, for one, which gets referenced
later in the failed mount paths - I haven't worked that out yet.

https://bugzilla.kernel.org/show_bug.cgi?id=30872

Reported-by: Eugene A. Shatokhin <dame_eugene@mail.ru>
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
fs/ext4/mballoc.c