xfs: trim eofblocks before collapse range
authorBrian Foster <bfoster@redhat.com>
Tue, 2 Sep 2014 02:12:53 +0000 (12:12 +1000)
committerDave Chinner <david@fromorbit.com>
Tue, 2 Sep 2014 02:12:53 +0000 (12:12 +1000)
commit41b9d7263ea1e270019c5d04fa0ab15db50b9725
tree6f26421d3050a5d1ca4eee95b8f39b2d34c34cb0
parent1669a8ca2105968f660cf7d84ba38fd18075cd99
xfs: trim eofblocks before collapse range

xfs_collapse_file_space() currently writes back the entire file
undergoing collapse range to settle things down for the extent shift
algorithm. While this prevents changes to the extent list during the
collapse operation, the writeback itself is not enough to prevent
unnecessary collapse failures.

The current shift algorithm uses the extent index to iterate the in-core
extent list. If a post-eof delalloc extent persists after the writeback
(e.g., a prior zero range op where the end of the range aligns with eof
can separate the post-eof blocks such that they are not written back and
converted), xfs_bmap_shift_extents() becomes confused over the encoded
br_startblock value and fails the collapse.

As with the full writeback, this is a temporary fix until the algorithm
is improved to cope with a volatile extent list and avoid attempts to
shift post-eof extents.

Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dave Chinner <david@fromorbit.com>
fs/xfs/xfs_bmap_util.c