Return early from getUnconditionalBranchTargetOpValue if the branch target is
authorLang Hames <lhames@gmail.com>
Mon, 28 Oct 2013 20:51:11 +0000 (20:51 +0000)
committerLang Hames <lhames@gmail.com>
Mon, 28 Oct 2013 20:51:11 +0000 (20:51 +0000)
commit3d478aee8e2480661cb0d98b10da8ad2ebf59fcf
treef5bc89bdef20e71120fcbe814e349b21eaaccae3
parent164bd156fc92dc738e5f8dce5da263e1d17211c4
Return early from getUnconditionalBranchTargetOpValue if the branch target is
an MCExpr, in order to avoid writing an encoded zero value in the immediate
field.

When getUnconditionalBranchTargetOpValue is called with an MCExpr target, we
don't know what the final immediate field value should be. We shouldn't
explicitly set the immediate field to an encoded zero value as zero is encoded
with a non-zero bit pattern. This leads to bits being set that pollute the
final immediate value. The nature of the encoding is such that the polluted
bits only affect very large immediate values, explaining why this hasn't
caused problems earlier.

Fixes <rdar://problem/15155975>.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@193535 91177308-0d34-0410-b5e6-96231b3b80d8
lib/Target/ARM/MCTargetDesc/ARMMCCodeEmitter.cpp
test/MC/ARM/basic-thumb2-instructions.s