genirq: Don't suspend nested_thread irqs over system suspend
authorNeilBrown <neilb@suse.de>
Sun, 17 May 2015 05:19:34 +0000 (15:19 +1000)
committerThomas Gleixner <tglx@linutronix.de>
Mon, 18 May 2015 15:23:47 +0000 (17:23 +0200)
commit3c646f2c6aa9e918d7fc77867df7f430059f9ccc
tree83cb34334d12c1ca9fcea185f36e75ed26cc6a61
parent63781394c540dd9e666a6b21d70b64dd52bce76e
genirq: Don't suspend nested_thread irqs over system suspend

Nested IRQs can only fire when the parent irq fires.  So when the
parent is suspended, there is no need to suspend the child irq.

Suspending nested irqs can cause a problem is they are suspended or
resumed in the wrong order.  If an interrupt fires while the parent is
active but the child is suspended, then the interrupt will not be
acknowledged properly and so an interrupt storm can result.  This is
particularly likely if the parent is resumed before the child, and the
interrupt was raised during suspend.

Ensuring correct ordering would be possible, but it is simpler to just
never suspend nested interrupts.

Signed-off-by: NeilBrown <neil@brown.name>
Cc: GTA04 owners <gta04-owner@goldelico.com>
Cc: Kalle Jokiniemi <kalle.jokiniemi@jollamobile.com>
Acked-by: Peter Zijlstra <peterz@infradead.org>
Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
Link: http://lkml.kernel.org/r/20150517151934.2393e8f8@notabene.brown
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
kernel/irq/pm.c